fix eslint, add to ci

This commit is contained in:
Dima Gerasimov 2019-01-06 20:49:39 +00:00 committed by Dmitrii Gerasimov
parent de46310d93
commit 3eb72bab9d
6 changed files with 15 additions and 5 deletions

View file

@ -28,6 +28,9 @@ jobs:
- run:
name: flow
command: npm run flow
- run:
name: eslint
command: npm run eslint
# - store_artifacts:
# path: test-results.xml
# prefix: tests

View file

@ -1,7 +1,12 @@
module.exports = {
"parser": "babel-eslint",
"plugins": [
"flowtype"
],
'extends': [
// "google",
"eslint:recommended",
"plugin:flowtype/recommended",
],
'env': {
'browser': true,

View file

@ -13,11 +13,13 @@
"@babel/core": "^7.2.2",
"@babel/preset-env": "^7.2.3",
"@babel/preset-flow": "^7.0.0",
"babel-eslint": "^10.0.1",
"clean-webpack-plugin": "^1.0.0",
"copy-webpack-plugin": "^4.2.0",
"css-loader": "^2.1.0",
"eslint": "^5.12.0",
"eslint-config-google": "^0.11.0",
"eslint-plugin-flowtype": "^3.2.0",
"file-loader": "^3.0.1",
"flow-bin": "^0.89.0",
"flow-interfaces-chrome": "^0.5.3",

View file

@ -88,7 +88,7 @@ chrome.commands.onCommand.addListener(command => {
}
});
chrome.runtime.onMessage.addListener((message: any, sender: chrome$MessageSender, sendResponse) => {
chrome.runtime.onMessage.addListener((message: any, sender: chrome$MessageSender, sendResponse) => { // eslint-disable-line no-unused-vars
if (message.method === METHOD_CAPTURE_WITH_EXTRAS) {
const comment = message.comment;
const tag_str = message.tag_str;

View file

@ -8,7 +8,7 @@ export function showNotification(text: string, priority: number=0) {
Notification.requestPermission();
} else {
// TODO ugh. is there no way to show in-browser only notification??
const notification = new Notification(
new Notification(
'grasp-notification',
// $FlowFixMe
{

View file

@ -30,7 +30,7 @@ function submitComment () {
'method': METHOD_CAPTURE_WITH_EXTRAS,
'comment': comment_text,
'tag_str': tag_str,
}, resp => {
}, () => {
console.log("[popup] captured!");
});
window.close();