From ea8d270a9fcd41d443b1358c792ff750e8994d4d Mon Sep 17 00:00:00 2001 From: Dima Gerasimov Date: Wed, 28 Dec 2022 00:36:50 +0000 Subject: [PATCH] fix alert after saving settings on firefox and chrome --- extension/src/js/options_page.js | 8 ++++++-- extension/src/manifest.json | 3 ++- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/extension/src/js/options_page.js b/extension/src/js/options_page.js index 89782ed..3151f46 100644 --- a/extension/src/js/options_page.js +++ b/extension/src/js/options_page.js @@ -72,8 +72,12 @@ async function saveOptions() { } await setOptions(opts) - // hmm seems that regular alert() doesn't work in chrome anymore - chrome.extension.getBackgroundPage().alert('Saved!') + // NOTE: seems that alert() only works here when we use open_in_tab: true for settings page + // when open_in_tab: false, then + // in chrome browser.extension.getBackgroundPage().alert works + // in firefox that doesn't work, seems that it refuses to alert from bg page + // so it seems easier to just always use opne_in_tab: true for setgings page + alert('Saved!') } diff --git a/extension/src/manifest.json b/extension/src/manifest.json index 22c3921..06ab305 100644 --- a/extension/src/manifest.json +++ b/extension/src/manifest.json @@ -9,7 +9,8 @@ "persistent": false }, "options_ui": { - "page": "options.html" + "page": "options.html", + "open_in_tab": false }, "icons": { "128": "img/unicorn.png"