diff --git a/bin/mov2gif b/bin/mov2gif index 5b763c0e..45ed31fa 100755 --- a/bin/mov2gif +++ b/bin/mov2gif @@ -2,20 +2,19 @@ usage() { echo "Usage: $0 [-f ] [-o ] [-h]"; } -if [[ $# = 0 ]]; then +if (($# == 0)); then >&2 echo "No movie file specified" exit -elif [[ ! -f "$1" ]]; then +elif [[ ! -f $1 ]]; then >&2 echo "$1 does not exist" exit fi fps=30 src="$1" -dest="${$(basename $src)%.mov}.gif" -while getopts hf:o: opt -do - case "$opt" in +dest="${${src##*/}%.mov}.gif" +while getopts hf:o: opt; do + case $opt in -f) fps="$OPTARG" ;; -o) dest="$OPTARG" ;; -h) usage @@ -34,4 +33,4 @@ flags="fps=${fps}" ffmpeg -v warning -i "$src" -vf "$flags,palettegen" -y "$palette" ffmpeg -v warning -i "$src" -i "$palette" -lavfi "$flags [x]; [x][1:v] paletteuse" -y "$dest" -[ -f "$palette" ] && rm -f "$palette" +[[ -f $palette ]] && rm -f "$palette"