From ed73b53c5891366c504687cb9c47a943dd53e812 Mon Sep 17 00:00:00 2001
From: ikipatang <5412352+ikipatang@users.noreply.github.com>
Date: Thu, 30 Nov 2017 14:09:59 +0100
Subject: [PATCH] Popup dimensions: can now be set in settings form

---
 src/options/options.css  | 10 ++++++++--
 src/options/options.html |  6 ++++++
 src/options/options.js   | 14 ++++++++++----
 3 files changed, 24 insertions(+), 6 deletions(-)

diff --git a/src/options/options.css b/src/options/options.css
index a2a80d2..c189610 100644
--- a/src/options/options.css
+++ b/src/options/options.css
@@ -4,13 +4,15 @@
 
 .main .row{
   text-align: left;
+  padding-top: 10px;
 }
 
 /* The form title */
 
 .main .row > label span{
   color: #1a1a1a;
-  width: 100em;
+  width: 200px;
+  display: inline-block;
   vertical-align: center;
   padding-left: 5px;
   padding-right: 30px;
@@ -24,10 +26,14 @@
   border: 1px solid #dbdbdb;
 }
 
+#popupWidth, #popupHeight {
+  width: 50px;
+  margin-right: 10px;
+}
+
 .main input[type=checkbox]{
   box-shadow: none;
   width: auto;
-  margin-top: 13px;
 }
 
 .main button{
diff --git a/src/options/options.html b/src/options/options.html
index 1c6b7ef..0189cbb 100644
--- a/src/options/options.html
+++ b/src/options/options.html
@@ -14,6 +14,12 @@
           <input id="url" type="text" name="url">
         </label>
       </div>
+      <div class="row">
+        <label>
+          <span>Popup dimensions (px)</span>
+          <input id="popupWidth" type="text" name="popupWidth"><input id="popupHeight" type="text" name="popupWidth"> (default : 900 x 600)
+        </label>
+      </div>
       <div class="row">
         <label>
           <span>Address bar</span>
diff --git a/src/options/options.js b/src/options/options.js
index e61677b..7d0350d 100644
--- a/src/options/options.js
+++ b/src/options/options.js
@@ -5,6 +5,8 @@
 function storeSettings() {
   const settings = {
     url: document.querySelector("#url").value,
+    popupWidth: parseInt(document.querySelector("#popupWidth").value),
+    popupHeight: parseInt(document.querySelector("#popupHeight").value),
     pageAction: document.querySelector("#pageAction").checked,
   };
   // console.log('storeSettings settings');
@@ -19,15 +21,19 @@ function storeSettings() {
  * @return {void}                     -
  */
 function updateUI(restoredSettings) {
+  // console.log('restoredSettings');
+  // console.dir(restoredSettings, { depth: 10, colors: true }); // DEBUG
+
   const url = document.querySelector("#url");
   url.value = restoredSettings.url;
-  // console.log('restoredSettings url');
-  // console.log(url);
+
+  const popupWidth = document.querySelector("#popupWidth");
+  popupWidth.value = restoredSettings.popupWidth;
+  const popupHeight = document.querySelector("#popupHeight");
+  popupHeight.value = restoredSettings.popupHeight;
 
   const pageAction = document.querySelector("#pageAction");
   pageAction.checked = restoredSettings.pageAction;
-  // console.log('restoredSettings pageAction');
-  // console.log(pageAction);
 }
 
 /**